Fix SoundStream::play to restart the sound if it was played before #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing that. I confirm that the behavior of the |
oomek
approved these changes
Aug 3, 2022
eXpl0it3r
approved these changes
Aug 3, 2022
|
Thanks for back porting this! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is similar to the fix I contributed in #2037 for master branch but this time for 2.6.x branch. I did not realize at first a part of the bug was also present in 2.6.x branch.
The bug is that calling
SoundStream::playafter the sound was played in full a first time does not restart the sound. The expected behavior according to this method documentation is to restart the sound.The fix is a little different from #2037 because we use
sf::Threadwhich does not provide ajoinablemethod likestd::threaddoes in master.Tasks
How to test this PR?
Running the
voipexample program.