Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor inconsistency in type cast in voip example #2222

Merged
merged 1 commit into from Oct 1, 2022

Conversation

kimci86
Copy link
Contributor

@kimci86 kimci86 commented Oct 1, 2022

because m_samples is a vector of Int16 values.

That's it for today. Thank you.

because m_samples is a vector of Int16 values.
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Oct 1, 2022
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Oct 1, 2022
@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.6.0 Oct 1, 2022
@vittorioromeo vittorioromeo self-requested a review October 1, 2022 16:13
SFML 2.6.0 automation moved this from Review & Testing to Ready Oct 1, 2022
@vittorioromeo
Copy link
Member

@eXpl0it3r: we can merge into 2.6.x, right?

@eXpl0it3r
Copy link
Member

@eXpl0it3r: we can merge into 2.6.x, right?

Fixes are fine, features should be discussed first.

@vittorioromeo vittorioromeo merged commit d0cf86d into SFML:2.6.x Oct 1, 2022
SFML 2.6.0 automation moved this from Ready to Done Oct 1, 2022
@kimci86 kimci86 deleted the voip_most_correct_cast branch October 1, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants