Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for macOS scancode implementation #2243

Merged
merged 20 commits into from
Dec 19, 2022
Merged

Fixes for macOS scancode implementation #2243

merged 20 commits into from
Dec 19, 2022

Commits on Dec 17, 2022

  1. Fix some comments placement

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    2485b89 View commit details
    Browse the repository at this point in the history

  2. Describe keys in separate words when applicable on macOS

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    0c0f49e View commit details
    Browse the repository at this point in the history

  3. Use "Option" instead of "Alt" to describe keys on macOS

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    2b2fda9 View commit details
    Browse the repository at this point in the history

  4. Handle Unknown in (de)localize methods on macOS

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    dbb4122 View commit details
    Browse the repository at this point in the history

  5. Name magic number for undefined scanToVirtualCode return value 

    and actually return it when appropriate.
    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    77c476d View commit details
    Browse the repository at this point in the history

  6. Filter key up events like key down events

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    d17512f View commit details
    Browse the repository at this point in the history

  7. Remember the first scancode mapped to each key

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    8cfeb5d View commit details
    Browse the repository at this point in the history

  8. HIDInputManager little bits of documentation

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    1aadc3e View commit details
    Browse the repository at this point in the history

  9. Move buildMappings to be consistent with the corresponding source file 

    and make the callback a static method so that buildMappings can be a
private method.
    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    7507d48 View commit details
    Browse the repository at this point in the history

  10. Order HIDInputManager method definitions like declarations

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    d37841d View commit details
    Browse the repository at this point in the history

  11. Use localize to generate keyboard events 

    That is better than translating to text because several keys can
generate the same text.
    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    b902e97 View commit details
    Browse the repository at this point in the history

  12. Replace deprecated key values

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    330d337 View commit details
    Browse the repository at this point in the history

  13. Do not translate some virtual key codes to avoid collisions 

    plus some mapping adjustments.
    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    079b83f View commit details
    Browse the repository at this point in the history

  14. Remove offset in numpad number scancode translation to key

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    dddc751 View commit details
    Browse the repository at this point in the history

  15. Add fallback mapping for NumpadEnter

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    11a27ea View commit details
    Browse the repository at this point in the history

  16. Remove redundant sf:: namespace specifiers

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    74b44bc View commit details
    Browse the repository at this point in the history

  17. Remove trailing spaces

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    74f486f View commit details
    Browse the repository at this point in the history

  18. Put back sf:: namespace specifier in initializeKeyboard comment

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    12d7c1d View commit details
    Browse the repository at this point in the history

  19. Handle swapped virtual key codes with ISO keyboard

    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    f542d64 View commit details
    Browse the repository at this point in the history

  20. Generate key events for caps lock when the modifier state changes 

    This is not accurate because modifier state and key state are not the
same thing for caps lock, but at least some events are generated
instead of nothing.
    @kimci86
    kimci86 committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    1706749 View commit details
    Browse the repository at this point in the history