Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DRM using the first possible video card without even checking if a monitor is connected #2246

Merged

Conversation

substring
Copy link
Contributor

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?
  • If you have additional steps which need to be performed list them as tasks!

Description

So far, SFML was just checking for DRM capable GFX cards without considering plugged monitors. On systems with multiple GFX cards where all monitors are connected to 1 card, SFML could pick the wrong card. To fix that, check if card connectors are connected to select/skip that card

Tasks

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

How to test this PR?

You need several GFX cards, monitor(s) plugged to only one GFX card.

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Oct 13, 2022
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Oct 13, 2022
@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.6.0 Oct 13, 2022
SFML 2.6.0 automation moved this from Review & Testing to Ready Oct 19, 2022
@eXpl0it3r eXpl0it3r merged commit 1d12c56 into SFML:2.6.x Oct 19, 2022
SFML 2.6.0 automation moved this from Ready to Done Oct 19, 2022
@eXpl0it3r
Copy link
Member

Thank you for adding this additional check! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants