Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of sf::Event::Resized #249

Merged
merged 1 commit into from
Jul 7, 2012
Merged

Fix behavior of sf::Event::Resized #249

merged 1 commit into from
Jul 7, 2012

Conversation

kimci86
Copy link
Contributor

@kimci86 kimci86 commented Jul 6, 2012

Here is a clean fix (I hope) for issue #68.
I tested it on Windows 7 and it is working as intended.

@LaurentGomila
Copy link
Member

It looks good. Have you tested it with different cases (window styles, sizes, actions, ...)?

@kimci86
Copy link
Contributor Author

kimci86 commented Jul 6, 2012

With those styles, resize events are pushed correctly :

  • Default
  • TitleBar | Resize
  • Close | Resize

With those styles, resize events are never pushed :

  • Close
  • Titlebar
  • Close | Titlebar
  • None
  • Fullscreen

I have tested the following actions :

  • Drawing the window edges, on every side (one event)
  • Minimizing and un-minimizing (no event)
  • Maximizing and un-maximizing (one event)

@LaurentGomila
Copy link
Member

Maximizing and un-maximizing (one event)

One event in total, or one event for each action?

@kimci86
Copy link
Contributor Author

kimci86 commented Jul 7, 2012

Maximizing and un-maximizing (one event)

One event in total, or one event for each action?

One event for each action.
Let me say that it also works when you double click the title bar.

@kimci86
Copy link
Contributor Author

kimci86 commented Jul 7, 2012

I wish to point out that I fixed an other bug by the way:
Before, the break for case WM_SIZE was into the if instructions.
This meant that on a minimise, a sf::Event::GainedFocus was pushed. :astonished:
See this line.

@LaurentGomila
Copy link
Member

Oh... Thanks
😓

LaurentGomila added a commit that referenced this pull request Jul 7, 2012
Fix behavior of sf::Event::Resized on Windows
@LaurentGomila LaurentGomila merged commit d22a318 into SFML:master Jul 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants