Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure doxygen STRIP_FROM_INC_PATH option #2512

Merged
merged 1 commit into from Apr 11, 2023

Conversation

kimci86
Copy link
Contributor

@kimci86 kimci86 commented Apr 11, 2023

so that include directives are correct in the generated documentation.

Before:
Capture d’écran du 2023-04-11 20-34-43

After:
Capture d’écran du 2023-04-11 20-35-11

Motivated by this comment: #2489 (comment)

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2.6.x@541e83e). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             2.6.x    #2512   +/-   ##
========================================
  Coverage         ?   26.62%           
========================================
  Files            ?      226           
  Lines            ?    19410           
  Branches         ?     4713           
========================================
  Hits             ?     5168           
  Misses           ?    13766           
  Partials         ?      476           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541e83e...b6c3c80. Read the comment docs.

@ChrisThrasher
Copy link
Member

Do the 2.6 docs have this same problem?

@kimci86
Copy link
Contributor Author

kimci86 commented Apr 11, 2023

Do the 2.6 docs have this same problem?

Yes it does. I guess I could target 2.6.x branch then.

so that include directives are correct in the generated documentation.
@kimci86 kimci86 force-pushed the bugfix/doxygen_strip_from_inc_path branch from 0db6cf6 to b6c3c80 Compare April 11, 2023 18:51
@kimci86 kimci86 changed the base branch from master to 2.6.x April 11, 2023 18:51
@ChrisThrasher ChrisThrasher added this to the 2.6 milestone Apr 11, 2023
@ChrisThrasher
Copy link
Member

I believe this would require Exploiter recreate the docs in SFML/SFML-Website#161.

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Apr 11, 2023
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.6.0 Apr 11, 2023
@eXpl0it3r eXpl0it3r merged commit a21c3c1 into SFML:2.6.x Apr 11, 2023
78 checks passed
SFML 2.6.0 automation moved this from Ready to Done Apr 11, 2023
@eXpl0it3r
Copy link
Member

Thanks for figuring out the missing piece and fixing it! 🥳

@kimci86 kimci86 deleted the bugfix/doxygen_strip_from_inc_path branch April 11, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants