Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and warnings in templates #2534

Merged

Conversation

vittorioromeo
Copy link
Member

No description provided.

Copy link
Member

@ChrisThrasher ChrisThrasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was this just an issue of no one having tested these templates in a long time and some errors built up?

@vittorioromeo
Copy link
Member Author

LGTM

Was this just an issue of no one having tested these templates in a long time and some errors built up?

I guess so, not even sure if these templates are used anymore, but worthwhile to fix any misleading/broken code anyway.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2534 (22916ac) into master (5480bf8) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
+ Coverage   27.14%   27.16%   +0.02%     
==========================================
  Files         228      228              
  Lines       19642    19642              
  Branches     4715     4715              
==========================================
+ Hits         5332     5336       +4     
- Misses      13839    13846       +7     
+ Partials      471      460      -11     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5480bf8...22916ac. Read the comment docs.

@eXpl0it3r eXpl0it3r added this to the 3.0 milestone Apr 24, 2023
@vittorioromeo vittorioromeo merged commit 2af0ba6 into SFML:master Apr 24, 2023
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants