Fix macOS Window Resizing Bug #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where resize events only got triggered upon manual window resizing OR if one called setSize with a height that was too large.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
+ Coverage 27.14% 27.18% +0.03%
==========================================
Files 228 228
Lines 19644 19639 -5
Branches 4712 4710 -2
==========================================
+ Hits 5333 5338 +5
- Misses 13615 13823 +208
+ Partials 696 478 -218
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
I cherry-picked this on top of the changes in #2519, since it has such a nice test application, and it worked correctly. And it might indeed be a candidate for SFML 2.6.1 |
eXpl0it3r
approved these changes
Apr 29, 2023
How about we use SFML 3 to test this out? If it work well in |
dogunbound
added a commit
to dogunbound/SFML
that referenced
this pull request
Jul 15, 2023
There is a commit up for the macOS resize bug where we get rid of a previous fix entiry and just resize, but kimci86 stated that he found better behavior with this solution. I'm going to put up this for code review and we can compare it to SFML#2538 and see which we like best
ChrisThrasher
pushed a commit
that referenced
this pull request
Jul 30, 2023
There is a commit up for the macOS resize bug where we get rid of a previous fix entiry and just resize, but kimci86 stated that he found better behavior with this solution. I'm going to put up this for code review and we can compare it to #2538 and see which we like best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where resize events only got triggered upon manual window resizing OR if one called
sf::WindowBase::setSizewith a height that was too large. This was caught during the testing of #2519. The reason we think it's a bug is that other windowing backends like X11 do emit a resize event whensetSizeis called.Brief testing proves that this works but I'm not sure if this has any unintended side effects so I'm not eager to merge until I understand the code better. This bug is present on 2.6.x as well in case we choose to backport this.