Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite module path #2577

Merged
merged 1 commit into from Jun 23, 2023
Merged

Don't overwrite module path #2577

merged 1 commit into from Jun 23, 2023

Conversation

ChrisThrasher
Copy link
Member

Description

The Conan package for SFML has to fix this so apparently it's a real world problem.

https://github.com/conan-io/conan-center-index/blob/master/recipes/sfml/all/patches/0001-cmake-robust-find-deps.patch

@ChrisThrasher ChrisThrasher added this to the 3.0 milestone Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2.6.x@11b7374). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d5f219e differs from pull request most recent head 242ceb4. Consider uploading reports for the commit 242ceb4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             2.6.x    #2577   +/-   ##
========================================
  Coverage         ?   27.47%           
========================================
  Files            ?      227           
  Lines            ?    19782           
  Branches         ?     4766           
========================================
  Hits             ?     5435           
  Misses           ?    13698           
  Partials         ?      649           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b7374...242ceb4. Read the comment docs.

The Conan package for SFML has to fix this so apparently it's a
real world problem.
@ChrisThrasher ChrisThrasher changed the base branch from master to 2.6.x June 22, 2023 20:34
@ChrisThrasher
Copy link
Member Author

ChrisThrasher commented Jun 22, 2023

Retargeted for 2.6.1 to allow for a little more cleanup of how SFML 2 is packaged. It will pay dividends to make packaging as easy as possible so that future releases can get out to package managers way faster. Updating patches for new releases is tedious work.

@ChrisThrasher ChrisThrasher merged commit 1f23f78 into 2.6.x Jun 23, 2023
58 checks passed
@ChrisThrasher ChrisThrasher deleted the module_path branch June 23, 2023 16:14
@eXpl0it3r eXpl0it3r modified the milestones: 3.0, 2.6.1 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants