Remove C++11 header #2591
Merged
Remove C++11 header #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was caught by someone writing a Conan package for SFML 2.6.0.
conan-io/conan-center-index#18069 (comment)
In practice this is a meaningless change but I'm fixing it for the sake of pedantry. Because C99 already provides fixed-width integers, we can rely on them. We can't use
sf::Uint64here since it's anunsigned longon some platforms andunsigned long longon others which apparently causes issues with using it as a parameter in a function pointer as is the case on line 112.