Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure OpenGL extensions have been loaded #2603

Merged
merged 1 commit into from Jul 4, 2023
Merged

Ensure OpenGL extensions have been loaded #2603

merged 1 commit into from Jul 4, 2023

Conversation

eXpl0it3r
Copy link
Member

Description

The OpenGL extensions first need to be loaded, to ensure we're not calling into the void.

This PR is related to the issue #2602

Tasks

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

How to test this PR?

Run the following example:

#include <iostream>
#include <SFML/Graphics/Texture.hpp>
int main() {
    std::cout << sf::Texture::getMaximumSize();
}

@eXpl0it3r eXpl0it3r added this to the 2.6.1 milestone Jul 4, 2023
@eXpl0it3r eXpl0it3r linked an issue Jul 4, 2023 that may be closed by this pull request
sf::Texture::getMaximumSize() segfaults #2602
Closed
@Bambo-Borris
Copy link
Contributor

Bambo-Borris commented Jul 4, 2023 •
edited

No crash on Windows 11 using this, nor on my WSL Ubuntu instance 😄

@ChrisThrasher
Copy link
Member

@dogunbound Let us know if this fixes your issue

@dogunbound
Copy link
Contributor

It works

@dogunbound dogunbound mentioned this pull request Jul 4, 2023
Closed
@eXpl0it3r eXpl0it3r merged commit 25920bb into 2.6.x Jul 4, 2023
58 checks passed
@eXpl0it3r eXpl0it3r deleted the bugfix/texture_ensure_extensions branch July 4, 2023 21:53
@eXpl0it3r eXpl0it3r mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binary1248 binary1248 binary1248 approved these changes

@ChrisThrasher ChrisThrasher ChrisThrasher approved these changes

Assignees
No one assigned
Labels
bug m:sfml-graphics
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.

sf::Texture::getMaximumSize() segfaults
5 participants
@eXpl0it3r @Bambo-Borris @ChrisThrasher @dogunbound @binary1248