Skip ClientMessage events with other window ID unless it is for IM #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves the issue for me. @MJJBennett could you try this branch? |
|
I can no longer reproduce the error |
|
Tested on my personal project and this fixes the problem I was seeing. Also tested to make 100% sure on my test project, and this definitely fixes the issue (the event is polled by the correct window). The change itself & comments also look great 👍 Thanks for fixing this! |
ChrisThrasher
approved these changes
Aug 15, 2023
|
Thank you! Glad to see 2.6.1 get yet another great bug fix like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to fix #2649.
Tasks
How to test this PR?
Running example program from issue #2649.