Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require that variables are initialized #2959

Merged
merged 1 commit into from Apr 27, 2024

Conversation

ChrisThrasher
Copy link
Member

Description

This new automated check is a good step towards systematically eliminating uninitialized reads. The only weird part was that I had to add some NOLINTs to Objecive-C++ code due to clang-tidy not entirely understanding Objective-C loops.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8858286583

Details

  • 82 of 162 (50.62%) changed or added relevant lines in 30 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 51.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SFML/Audio/AudioDevice.cpp 0 1 0.0%
src/SFML/Network/Http.cpp 1 2 50.0%
src/SFML/Network/TcpSocket.cpp 1 2 50.0%
src/SFML/Window/DRM/InputImpl.cpp 0 1 0.0%
src/SFML/Window/Win32/WglContext.cpp 0 1 0.0%
src/SFML/Window/macOS/JoystickImpl.cpp 0 1 0.0%
src/SFML/Audio/SoundRecorder.cpp 0 2 0.0%
src/SFML/Window/Unix/JoystickImpl.cpp 1 3 33.33%
src/SFML/Window/Win32/WindowImplWin32.cpp 0 2 0.0%
src/SFML/Window/macOS/InputImpl.mm 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/SFML/Window/DRM/DRMContext.cpp 1 0.0%
src/SFML/Audio/MiniaudioUtils.cpp 1 0.0%
src/SFML/Window/Win32/JoystickImpl.cpp 1 10.36%
src/SFML/Window/Unix/WindowImplX11.cpp 2 42.5%
Totals Coverage Status
Change from base Build 8841003784: -0.02%
Covered Lines: 10435
Relevant Lines: 19108

💛 - Coveralls

@ChrisThrasher ChrisThrasher merged commit 249caa2 into master Apr 27, 2024
209 checks passed
@ChrisThrasher ChrisThrasher deleted the clang-tidy-init-variables branch April 27, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants