Replaced SoundFileReaderWav implementation with miniaudio (dr_)wav decoder #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary1248
force-pushed
the
feature/miniaudio_wav
branch
from
ef1cf30
to
4199eef
Compare
Pull Request Test Coverage Report for Build 9121879561Details
💛 - Coveralls |
ChrisThrasher
approved these changes
May 17, 2024
eXpl0it3r
approved these changes
May 17, 2024
|
Thank you for switch the decoder! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Closes #1777.
If anyone is wondering why the writer wasn't also replaced, our current implementation supports writing in extensible format which supports embedding channel mapping data, whereas the miniaudio implementation doesn't as far as I can tell. The reasoning behind replacing the decoder (see #1777: slow, doesn't support exotic formats) also doesn't really apply to replacing the writer as well. If we ever get reports about performance issues with the writer it will be easy to optimize.