Update self-referential owner ptr when moving SoundStream
#3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vittorioromeo
force-pushed
the
bugfix/update_selfreferential_soundstream_ptr
branch
2 times, most recently
from
9cac5ac
to
a7cf699
Compare
vittorioromeo
force-pushed
the
bugfix/update_selfreferential_soundstream_ptr
branch
from
a7cf699
to
9605212
Compare
eXpl0it3r
reviewed
Jun 10, 2024
eXpl0it3r
force-pushed
the
bugfix/update_selfreferential_soundstream_ptr
branch
from
9605212
to
8215f94
Compare
eXpl0it3r
approved these changes
Jun 10, 2024
Pull Request Test Coverage Report for Build 9455261812Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this self-referential pointer when implementing move semantics for
sf::Musicin #3075. Handles the latest ASAN issue in #3079, but the first reported one still occurs.