New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved stb_image into the extlibs directory. #795

Merged
merged 1 commit into from Feb 10, 2015

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented Feb 6, 2015

Title says it all. 馃榿

@binary1248 binary1248 self-assigned this Feb 6, 2015

@binary1248 binary1248 added this to the 2.3 milestone Feb 6, 2015

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Feb 6, 2015

Member

Can't we have

#include <stb_image/stb_image.h>
#include <stb_image/stb_image_write.h>

... so that we avoid an extra include path for it, and it follows the implicit convention of <library/header> includes (which avoids conflicts in case of headers named the same way, such as config.h).

Member

LaurentGomila commented Feb 6, 2015

Can't we have

#include <stb_image/stb_image.h>
#include <stb_image/stb_image_write.h>

... so that we avoid an extra include path for it, and it follows the implicit convention of <library/header> includes (which avoids conflicts in case of headers named the same way, such as config.h).

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Feb 6, 2015

Member

The other libraries are also handled like that. Look at the jpeg headers right underneath them.

Member

binary1248 commented Feb 6, 2015

The other libraries are also handled like that. Look at the jpeg headers right underneath them.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Feb 6, 2015

Member

Hmm ok, whatever.

Member

LaurentGomila commented Feb 6, 2015

Hmm ok, whatever.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Feb 7, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Feb 7, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 5dbfb47 into master Feb 10, 2015

@eXpl0it3r eXpl0it3r deleted the feature/move_stb_image branch Feb 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment