Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix compiler warnings #246

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Add and fix compiler warnings #246

merged 2 commits into from
Aug 2, 2023

Conversation

ChrisThrasher
Copy link
Member

Silencing the OpenGL deprecation warnings was my first goal since they were cluttering up the console output. While I was in there I added a quick a few lines to add the most basic GCC and Clang warnings. I see a few other PRs are touching on compiler warnings as well so this helps lay the groundwork to add (and fix) more warnings in the future.

I also kept another commit that fixes a little typo I found a few days ago.

@oprypin oprypin merged commit b2e7aa2 into master Aug 2, 2023
22 checks passed
@oprypin oprypin deleted the compiler_warnings branch August 2, 2023 10:37
@oprypin
Copy link
Member

oprypin commented Aug 2, 2023

Hold up- I didn't think this through so well. This means that if in the future the compilers start spewing more warnings, people will not be able to build the project?

@ChrisThrasher
Copy link
Member Author

ChrisThrasher commented Aug 2, 2023

This means that if in the future the compilers start spewing more warnings, people will not be able to build the project?

Theoretically yes, but in practice not likely with this basic set of warnings. Regardless it still may be a good idea to add a cache variable to disable -Werror like SFML has.

For now let's focus on adding and fixing more warnings because the #1 way to address potential compiler warnings is to aggressively find and fix them. We need to enable and fix more warnings until we approach the set of warnings that SFML uses. That will require some extra stuff to make sure we don't apply any warnings to the ImGui source code that we're compiling. Once we get there the code will be overall cleaner and less likely to cause issues when 3rd parties build it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants