Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typos and unreachable commands, indents, etc. #1158

Merged
merged 1 commit into from Sep 25, 2019
Merged

Fixed typos and unreachable commands, indents, etc. #1158

merged 1 commit into from Sep 25, 2019

Conversation

simonsan
Copy link
Contributor

Some things found by clang-tidy and IDE.

@simonsan simonsan added the improvement Enhancement of an existing component label Sep 25, 2019
@simonsan simonsan force-pushed the Fix-typos-clang-tidy-stuff branch 5 times, most recently from acf0cb5 to 05c2335 Compare September 25, 2019 07:26
heinezen
heinezen requested changes Sep 25, 2019
View reviewed changes
doc/reverse_engineering/networking/08-movement.md Outdated Show resolved Hide resolved
doc/reverse_engineering/networking/13-other.md Outdated Show resolved Hide resolved
heinezen
heinezen requested changes Sep 25, 2019
View reviewed changes
doc/reverse_engineering/networking/15-c-structs.md Outdated Show resolved Hide resolved
doc/reverse_engineering/networking/15-c-structs.md Outdated Show resolved Hide resolved
doc/reverse_engineering/networking/15-c-structs.md Outdated Show resolved Hide resolved
doc/reverse_engineering/networking/15-c-structs.md Outdated Show resolved Hide resolved
heinezen
heinezen requested changes Sep 25, 2019
View reviewed changes
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some small things to correct. Otherwise it looks good 🤖

libopenage/util/compress/lzxd.cpp Outdated Show resolved Hide resolved
libopenage/input/input_manager.cpp Show resolved Hide resolved
libopenage/input/input_manager.cpp Show resolved Hide resolved
libopenage/terrain/terrain.cpp Outdated Show resolved Hide resolved
@heinezen heinezen added the lang: c++ Done in C++ code label Sep 25, 2019
@simonsan simonsan added the documentation Involves the project documentation label Sep 25, 2019
@simonsan simonsan force-pushed the Fix-typos-clang-tidy-stuff branch 3 times, most recently from 489f892 to 048d67f Compare September 25, 2019 14:28
heinezen
heinezen requested changes Sep 25, 2019
View reviewed changes
doc/nyan/api_reference/reference_aux.md Outdated Show resolved Hide resolved
@simonsan simonsan merged commit 3b4d46f into SFTtech:master Sep 25, 2019
@simonsan simonsan deleted the Fix-typos-clang-tidy-stuff branch September 25, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen heinezen approved these changes

Assignees
No one assigned
Labels
documentation Involves the project documentation improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonsan @heinezen