Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Adding Github workflows #1196

Closed
wants to merge 2 commits into from

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Nov 20, 2019

ci: adding windows and ubuntu workflows,
doc: adding status badges for mac and win to readme.md

For the caching there is still some fine-tuning needed in the future. I'm also waiting for an increase of the limit and possibility to cache vcpkg/installed-dir of github-actions (actions/cache#6) and adding vcpkg packages to the virtual env (actions/runner-images#11) and that Qt gets added to the images (actions/runner-images#8). That overall could lower the win build for around 12 minutes.

The Ubuntu-CI is not running inside this main repo, but just outside for any forks of openage. People can make future use of this for pre-diagnosing clang-tidy-errors or clang-format-stuff inside their forked repositories. This functionality (clang-tidy and clang-format) is not added with this PR though and might come in the future.

Win

  • Investigate after build test output not being forwarded by shell
  • Packaging Nightly builds directly on Github Releases
  • Look into install prefix on x64 target being program files (x86) => Around this function (thanks tu) (can't reproduce for now, later?)
  • User PWSH interface to Windows Defender to scan package before publishing
  • Make use of Compiler Cache (clcache, cclash)
  • Add build matrix for cases (versions of Python (Upstream Issue) or included in win environments, versions of compilers)
    • Python
    • MSVC would be a good start into a build matrix => only Visual Studio 2019 on newest Windows builds
    • Architecture is not needed now, but prepared, as we are not building/testing/packaging for 32bit platforms currently
  • Add caching for vcpkg-dir using run-vcpkg (example using run-cmake as well)

Win-MSYS2

  • MSYS2 could be an easy replacement where we could build on gcc/g++ and clang as well in a build matrix setup (would be easy to cache as well, one folder)
  • Packaging Nightly builds directly on Github Releases
  • Make use of ccache

Linux

Mac

  • Packaging?
  • Add build matrix for cases (versions of Python, versions of compilers)
  • Check current workflow for fonts problem
  • Wait for the 2 GiB individual cache limit and cache brew+llvm, use brew again to install Qt

@simonsan simonsan added os: windows Windows-specific issue os: linux Linux-specific issue documentation Involves the project documentation ci Related to our continuous integration systems (kevin, github-actions, ...) labels Nov 20, 2019
Copy link
Contributor Author

@simonsan simonsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts:

.github/workflows/windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved
@simonsan simonsan changed the title [WIP] Adding Github workflows for Win + Fallback/CI for forks on Ubuntu Adding Github workflows for Win + Fallback/CI for forks on Ubuntu Nov 20, 2019
@simonsan simonsan changed the title Adding Github workflows for Win + Fallback/CI for forks on Ubuntu [WIP] Adding Github workflows for Win + Fallback/CI for forks on Ubuntu Nov 20, 2019
@simonsan simonsan force-pushed the github-workflows branch 19 times, most recently from 00847be to 357f838 Compare November 20, 2019 20:26
@simonsan simonsan force-pushed the github-workflows branch 13 times, most recently from f4f4320 to 07a3e96 Compare November 23, 2019 17:59
@simonsan simonsan force-pushed the github-workflows branch 2 times, most recently from 63bdb22 to 080076a Compare November 29, 2019 19:48
@simonsan
Copy link
Contributor Author

simonsan commented Jan 7, 2020

Cache limit for workflows got increased, so we probably could cache the complete Qt and vcpkg dir to make build times smaller.

per-cache limit to 2GB to match the per-repo limit
Ref.: actions/cache#6 (comment)

@simonsan simonsan marked this pull request as draft April 24, 2020 07:08
@simonsan simonsan changed the title [WIP] Adding Github workflows Adding Github workflows Apr 24, 2020
@simonsan simonsan changed the title Adding Github workflows [Umbrella] Adding Github workflows Apr 26, 2020
@simonsan simonsan added the os: macos macOS-specific issue label Apr 28, 2020
@simonsan simonsan force-pushed the github-workflows branch 2 times, most recently from 2d6a62d to 532cf13 Compare April 30, 2020 00:03
@simonsan simonsan mentioned this pull request May 2, 2020
13 tasks
@simonsan
Copy link
Contributor Author

(Outdated)

@simonsan simonsan closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to our continuous integration systems (kevin, github-actions, ...) documentation Involves the project documentation os: linux Linux-specific issue os: macos macOS-specific issue os: windows Windows-specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants