Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrain format specification #1318

Merged
merged 17 commits into from Feb 26, 2021
Merged

Terrain format specification #1318

merged 17 commits into from Feb 26, 2021

Conversation

heinezen
Copy link
Member

Specification for the improved .terrain format discussed in #965 .

A few significant changes were made in comparison to version 0.

  • blending_priority: Changed from its own attribute to a parameter of blending_mask. This allows us to define multiple blending mask with different priority values which could be useful for animated terrain textures.
  • dots_per_tile: Now removed. I think we can leave this out if the engine is not tile-based anyway. Drawing the texture and blending should not require information about tiling.
  • scalefactor: Included here with same purpose as in the sprite format (version 1).
  • blend_id : Is now optional for a frame. If omitted, the blending mask of adjacent textures is always used.

@heinezen heinezen marked this pull request as draft September 16, 2020 14:36
@heinezen heinezen requested a review from TheJJ September 16, 2020 14:36
@heinezen heinezen added area: assets Involved with assets (images, sounds, ...) documentation Involves the project documentation area: renderer Concerns our graphics renderer labels Sep 16, 2020
@heinezen heinezen marked this pull request as ready for review September 21, 2020 07:39
TheJJ
TheJJ requested changes Sep 23, 2020
View reviewed changes
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Dec 28, 2020
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Dec 28, 2020
@heinezen heinezen force-pushed the terrain_format branch 2 times, most recently from 15abb6f to 5757f5a Compare December 29, 2020 05:28
@heinezen heinezen requested a review from TheJJ January 6, 2021 09:07
TheJJ
TheJJ requested changes Jan 21, 2021
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting there!

doc/media/openage/blendtable_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/blendmask_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/blendtable_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/blendmask_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/blendmask_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Outdated Show resolved Hide resolved
@heinezen heinezen requested a review from TheJJ February 13, 2021 03:39
@TheJJ TheJJ self-assigned this Feb 25, 2021
TheJJ
TheJJ requested changes Feb 26, 2021
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully only one thing left

doc/media/openage/palette_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/terrain_format_spec.md Show resolved Hide resolved
TheJJ
TheJJ approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@TheJJ TheJJ merged commit 176e8bf into SFTtech:master Feb 26, 2021
@heinezen heinezen mentioned this pull request Mar 3, 2021
Merged
@heinezen heinezen deleted the terrain_format branch October 13, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees

@TheJJ TheJJ

Labels
area: assets Involved with assets (images, sounds, ...) area: renderer Concerns our graphics renderer documentation Involves the project documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heinezen @TheJJ @SFTbot