-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cython 3 problems #1523
Fix Cython 3 problems #1523
Conversation
Quick fix. There should be a better solution.
run.py.in
Outdated
@@ -11,8 +11,12 @@ which satisifies that requirement. | |||
""" | |||
|
|||
if __name__ == '__main__@SOME_UNDEFINED_VARIABLE_CMAKE_WILL_REMOVE@': | |||
# This is stupid but without it, Cython/Python cannot find the openage module. | |||
import sys | |||
sys.path.append('./bin') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to either run it in bin/ or add
this path dynamically if we detect we're in the build dir currently- it shouldn't be generally added since this may be the installed openage binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run it in bin
but it failed regardless. Don't know why but it worked before for earlier cython versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm well, but we shpuld try a proper fix (which may include adding py paths of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to sys.path.append(os.getcwd())
.
Cython 3 changes a few things which caused trouble in the builds.