Fix Cython 3 problems #1523
Merged
Fix Cython 3 problems #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix. There should be a better solution.
heinezen
added
lang: c++
TheJJ
requested changes
Jul 22, 2023
run.py.in
Outdated
| @@ -11,8 +11,12 @@ which satisifies that requirement. | |||
| """ | |||
|
|
|||
| if __name__ == '__main__@SOME_UNDEFINED_VARIABLE_CMAKE_WILL_REMOVE@': | |||
| # This is stupid but without it, Cython/Python cannot find the openage module. | |||
| import sys | |||
| sys.path.append('./bin') | |||
There was a problem hiding this comment.
you have to either run it in bin/ or add
this path dynamically if we detect we're in the build dir currently- it shouldn't be generally added since this may be the installed openage binary
There was a problem hiding this comment.
I did run it in bin but it failed regardless. Don't know why but it worked before for earlier cython versions.
There was a problem hiding this comment.
hm well, but we shpuld try a proper fix (which may include adding py paths of course)
There was a problem hiding this comment.
changed it to sys.path.append(os.getcwd()).
heinezen
added
the
kevin-rebuild-pl0x
SFTbot
removed
the
kevin-rebuild-pl0x
TheJJ
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython 3 changes a few things which caused trouble in the builds.