Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang build #1560

Merged
merged 2 commits into from Oct 7, 2023
Merged

Fix clang build #1560

merged 2 commits into from Oct 7, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Oct 6, 2023

Fixes #1556

  • Removes pre-processor error when std::jthread is not found
  • Fixes another weird substitution error in renderer

@heinezen heinezen added area: renderer Concerns our graphics renderer area: simulation Involved in the game mechanics and simulation bugfix Restores intended behavior labels Oct 6, 2023
@TheJJ TheJJ merged commit af1cd5a into SFTtech:master Oct 7, 2023
8 of 13 checks passed
@heinezen heinezen deleted the fix-clang branch October 7, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
area: renderer Concerns our graphics renderer area: simulation Involved in the game mechanics and simulation bugfix Restores intended behavior
Projects
openage game simulation
Status: ✅ Done
openage renderer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build with clang, error: "jthread is supported now, remove custom definition"
2 participants
@heinezen @TheJJ