Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter debug #1591

Merged
merged 2 commits into from Nov 1, 2023
Merged

Converter debug #1591

merged 2 commits into from Nov 1, 2023

Conversation

fabiobarkoski
Copy link
Contributor

Created debug output for sounds not found on exporting stage and for execution time for each stage

resolve: #1343

copying.md Outdated
@@ -148,6 +148,7 @@ _the openage authors_ are:
| Zoltán Ács | zoli111 | acszoltan111 à gmail dawt com |
| Trevor Slocum | tslocum | trevor à rocket9labs dawt com |
| Munawar Hafiz | munahaf | munawar dawt hafiz à gmail dawt com |
| Fábio Barkoski | fabiobarkoski | fabiobarkoskii à gmail dawt com |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz align the last column :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the last vertical bar, my bad

openage/convert/service/debug_info.py Outdated Show resolved Hide resolved
@heinezen heinezen added the hacktoberfest-accepted For accepted PRs for Hacktoberfest event label Oct 31, 2023
added condition to now supported SLD files
created debug output for sounds not found on exporting stage
and for execution time for each stage
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fabiobarkoski fabiobarkoski marked this pull request as ready for review November 1, 2023 18:00
@heinezen heinezen merged commit 655bba2 into SFTtech:master Nov 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted For accepted PRs for Hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance output summary of converter run for debugging
2 participants