This is a simple to use and efficient rng. #191
Conversation
|
Is there a specific reason to implement a new rng instead of using one from the c++ standard library. Further the Travis build fails. |
|
Building in provides stronger guarantees of reproducibility, as well as guarantees that serialization is the same. According to the standard, the stl rng implementations themselves should all have identical output. GCC and Clang both follow that atm, but I don't know about ICC or VC++. I wasn't able to find any information governing the serialization of generators. The standard ones all support stream output, but I don't know how well that translates across implementation. Also, pretty much everything that's implemented in the class besides random, discard, and seed would need to be implemented anyways. The distributions that are provided by the stl to go from random uint64 -> something useful are not standardized and do actually differ across implementations, and I couldn't find anything about serialization portability. |
TheJJ
added
lang: c++
| rng_tests.cpp | ||
| ) | ||
|
|
||
| add_test_cpp(openage::rng::tests::rng_tests "test functionality of rng - this *may* fail due to a statistical anomaly, but is extremely unlikely") |
There was a problem hiding this comment.
lolwhat 😆
could you add some comment what could fail there?
|
Apart from the above comments, awesome work, code, docs and tests are pretty easy to read and understand. Nicely done. |
schets
force-pushed
the
simple-rng
branch
3 times, most recently
from
79b6898
to
026a17c
Compare
It provides an easy and reliable way of reproducible random numbers, along with platform-independent serialization.
|
|
||
| std::ostream &rng::to_stream(std::ostream &out) const { | ||
| if((out << this->state[0] << " ").good() && | ||
| !(out << this->state[1]).fail()) { |
There was a problem hiding this comment.
Why are you using !(...).fail() instead of good()?
|
The code looks ok. Nevertheless it would be nice to have some comments about the mathematical background. |
|
[vortigaunt] |
|
i'm continuing the work in #221, thanks again. |
It provides an easy and reliable way of reproducible random numbers,
along with platform-independent serialization. There is also a thread-safe global rng, although it makes no promises about the order in which requests will be processed.