Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic version drawing #66

Closed
wants to merge 1 commit into from
Closed

Conversation

oldlaptop
Copy link
Contributor

 * Lower left corner, toggled by F1. Uses essentially the same
   technique as the FPS counter, since I shamelessly stole that
   code.
@mic-e
Copy link
Member

mic-e commented Oct 31, 2014

No need to be ashamed about stealing code that's in the same file (except when it would lead to code duplication, which it doesn't). To be compatible with Minecraft's interface, I suggest using F3 instead, and using that to toggle FPS as well.

@mic-e
Copy link
Member

mic-e commented Oct 31, 2014

Also, minor code issue: the correct place for the Engine::drawing_version default value would be here, to keep in line with the current code (which I don't like; I'd actually prefer the default value to be in the header. Gonna have to change that some time). Oh, and please put your name in the authors list in copying.md.

@oldlaptop oldlaptop closed this Oct 31, 2014
@oldlaptop oldlaptop deleted the draw_version branch October 31, 2014 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render the game version on screen
2 participants