Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit.py #718

Closed
wants to merge 1 commit into from
Closed

Update unit.py #718

wants to merge 1 commit into from

Conversation

yvan-burrie
Copy link
Contributor

Added clarifications and filled unknowns, only by comments.

@yvan-burrie
Update unit.py
c956cc6 
Added clarifications and filled unknowns, only by comments.
@zuntrax zuntrax added the documentation Involves the project documentation label Jan 24, 2017
@TheJJ TheJJ added the lang: python Done in Python code label Jan 24, 2017
@TheJJ
Copy link
Member

TheJJ commented Jan 24, 2017

It's ok to also rename and update the variables directly :)
The build will fail if you rename an exported value that is used in the code.

You can use curl -N build-details-link on your terminal to see the build output.

Thanks for the updates though, I think our dat file can never be complete enough, so keep going!

@TheJJ TheJJ mentioned this pull request Mar 1, 2017
Merged
30 tasks
@TheJJ
Copy link
Member

TheJJ commented Mar 1, 2017

I'm integrating this in #723 because it will require a data reconversion anyway.

@TheJJ
Copy link
Member

TheJJ commented Mar 21, 2017

Done.

@TheJJ TheJJ closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Involves the project documentation lang: python Done in Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yvan-burrie @TheJJ @zuntrax