Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsystem: let automoc depend on codegen #909

Merged
merged 2 commits into from
Sep 7, 2017

Conversation

TheJJ
Copy link
Member

@TheJJ TheJJ commented Sep 5, 2017

Fixes #907.

Otherwise build may fail because there's
no known recipe to generate the files.

We should maybe tune the codegen target to actually have all the generated files as output, not just the timefile. This now was the easier fix, though.
The codegen custom command now knows all its output, but the codegen target still depends on the timefile only, so the command isn't run for every generated source.

otherwise build may fail because there's
no known recipe to generate the files.
@TheJJ TheJJ added bugfix Restores intended behavior area: buildsystem Related to our cmake/python buildsystem labels Sep 5, 2017
Copy link
Contributor

@Tomatower Tomatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, -j64 still does not trigger the referred bug.

@Tomatower Tomatower merged commit ca2cbae into SFTtech:master Sep 7, 2017
@TheJJ TheJJ deleted the codegenfix branch September 10, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: buildsystem Related to our cmake/python buildsystem bugfix Restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial build on x86-64 fails. Works after manually invoking 'make codegen'
2 participants