Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid coarsening in the datamining pipeline #200

Merged
merged 14 commits into from
Feb 26, 2020

Conversation

janschopohl
Copy link
Contributor

No description provided.

@spc90
Copy link
Member

spc90 commented Feb 20, 2020

@janschopohl In GridFactory.i on line 68 the % of the include ended up on the previous line. I assume that is what causes the travis crashes. If you don't have time to fix it, I can also do it. Sometime later this week I'll review the whole pull request changes :)

@janschopohl
Copy link
Contributor Author

Something went wrong with the auto formatting, should be fixed now.

spc90
spc90 previously approved these changes Feb 24, 2020
@spc90 spc90 self-requested a review February 24, 2020 09:43
spc90
spc90 previously approved these changes Feb 25, 2020
Copy link
Member

@spc90 spc90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes before merging were already reviewed

spc90
spc90 previously approved these changes Feb 26, 2020
@spc90 spc90 merged commit e5c7b7c into SGpp:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants