-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better PicoScan lidars support #256
Comments
Thanks for your feedback. We will discuss support of Profiling Systems with SICK. |
We still have a problem with the SickScanApiClose function. When it's called in the sick_scan_xd_api_test example, the function is never exited, so the rest, such as SickScanApiRelease, is never called (tested with breakpoints). We've noticed that the s_scanner variable is not allocated for picoscans (in sick_generic_laser.cpp file at lines 437-439) and when stopScannerAndExit(bool force_immediate_shutdown) is called in sick_generix_laser.cpp, it never goes through s_scanner->stopScanData(force_immediate_shutdown). Any ideas? |
Many thanks for following up! The previous fix was incomplete. Please use the updated version in branch https://github.com/SICKAG/sick_scan_xd/tree/feature/api_exit and rebuild. Note that this version is collected update with several changes incl. cleanup at API exit. |
The problem under Windows for picoScan doesn't seem to have been solved. Thank you for taking the time to answer our questions. |
@paulinelvne Many thanks for your feedback and the detailed error description! Please find an update in branch https://github.com/SICKAG/sick_scan_xd/tree/feature/api_exit, which corrects closing receiver threads at API exit. |
Thank you very much ! Switching off the picoScan works correctly |
@paulinelvne Thanks for your support! |
We are in the process of integrating the new PicoScan sensors through this library and we did encounter a few issues.
Performance Profile parameter
We had to modify the library to be able to change the "performance profile" parameter of the lidar. We only partially succeeded as we are only able to change to profiles from 0 to 9, and not to 10. See the pull request we did here.
Example crashing when deregistering the library
The picoScan cannot stop properly because an issue occurs when calling one of the following 3 functions at the end of the sick_scan_xd_api_test example :
For now, we haven't found a way to fix this issue.
The text was updated successfully, but these errors were encountered: