Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PicoScan performance profile parameter in launch file #255

Conversation

paulinelvne
Copy link

Add basic support for setting the PicoScan's performance profile parameter from the launch file.

For now, we can set the "performance profile" parameter from 0 to 9. With those changes we are able to set the performance profile number when calling SickScanApiInitByLaunchfile, by adding an argument like this:

./sick_picoscan.launch hostname:=<LIDAR_IP> performanceprofilenumber:=9

Issues remaining:

  • passing a value of 10 (for Prime and Pro models of PicoScan) does not work
  • when sending commands to the lidar, the "sendMultiScanStartCmd()" function is called when using a picoscan. It seems to be working but a bit strange.

@rostest
Copy link
Collaborator

rostest commented Jan 8, 2024

Thank you very much for this pull request. We will discuss a possible support of Profiling Systems with SICK and will come back to it.

@rostest
Copy link
Collaborator

rostest commented Jan 23, 2024

Thanks again for the PR. It will be merged into the next release. Note that picoScan lidars support profiles from 0 to 9 (a value of 10 is not supported).

@paulinelvne
Copy link
Author

I've just tested with a performanceprofilenumber = 0, it doesn't work.
The only performanceprofiles that work are those from 1 to 9, which is problematic because you can't set profile 10 (40Hz 0.125°).

Thank you for your time

@rostest
Copy link
Collaborator

rostest commented Jan 24, 2024

@paulinelvne Profile 10 can be set, but has to be encoded with hexvalue 0xA in the SOPAS command. Please find an update in branch https://github.com/SICKAG/sick_scan_xd/tree/feature/picoscan_performanceprofile, which merges your PR incl. the conversion to hexvalues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants