Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to user profile by name #95

Closed

Conversation

toshitapandey
Copy link

Proposed Changes

  • The user profile can be accessed via the email instead of id. Since there is no username available, email will act as one.

Issue Related

How Was This Tested?

  • Checked by logging in and going to the profile by replacing /1 with / on my local machine

Checklist

  • This Pull Request has a significant name.
  • The commits follow the [[commits policy]].
  • The build is okay (tests, code climate).
  • This Pull Request mentions a related issue.
  • The change was necessary to the progress of the project.

This was referenced Oct 18, 2018
@arthurbdiniz
Copy link

Hi @toshitapandey we love your PR!
I test it and found some issues. We know how to fix it. To approve this PR could you please just update your branch with branch feature/routing and change the base to feature/routing

image

@arthurbdiniz arthurbdiniz changed the title go to user profile by name Go to user profile by name Oct 22, 2018
@arthurbdiniz
Copy link

Devido a inatividade desse PR ele está sendo fechado

@toshitapandey
Copy link
Author

@arthurbdiniz Is this closed? I can not find the feature/routing branch at the moment?

@arthurbdiniz
Copy link

arthurbdiniz commented Feb 14, 2019

@arthurbdiniz Is this closed? I can not find the feature/routing branch at the moment?

@toshitapandey we gave up on this issue because we saw that is more complex than we think. A lot of code needed to be changed to achieve a nice result. Anyway thanks for your contribution! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants