Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftLint #8

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Add SwiftLint #8

merged 5 commits into from
Jul 12, 2023

Conversation

31aditya0193
Copy link
Contributor

@31aditya0193 31aditya0193 commented Jul 11, 2023

On the way to Add SwiftLint

  • Add SwiftLint.yml.
  • fixed some warning.

@Mcrich23
Copy link
Collaborator

@31aditya0193 Can you please add swift lint to this pr?

@Mcrich23
Copy link
Collaborator

All you have to do is make another commit to the branch and it will auto update

@Mcrich23
Copy link
Collaborator

Also, please add this as a github action:

# This is a basic workflow to help you get started with Actions

name: CI

# Controls when the workflow will run
on:
  push:
    branches:
    - main
    - dev
  pull_request:
    branches:
    - main
    - dev
  workflow_dispatch: # Allows you to run this workflow manually from the Actions tab

jobs:
  SwiftLint:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v1
    - name: GitHub Action for SwiftLint
      uses: norio-nomura/action-swiftlint@3.2.1

This way in the future, prs auto get swift lint checked

@31aditya0193 31aditya0193 changed the title fix some swift lint Issues Add SwiftLint Jul 11, 2023
Copy link
Collaborator

@Mcrich23 Mcrich23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Mcrich23 Mcrich23 requested a review from ccahsh July 12, 2023 16:57
@ccahsh ccahsh merged commit 342c658 into SIMPLE-SECURITY:main Jul 12, 2023
1 of 2 checks passed
@ccahsh ccahsh mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants