テーブル機能を実装 #6
Merged
テーブル機能を実装 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
フィルタすべき項目は以上ですか？本当に？？ |
MogamiTsuchikawa
requested changes
Apr 1, 2023
pages/users.tsx
Outdated
| return ( | ||
| <div style={{ width: "100%" }} className="overflow-auto"> | ||
| {allTableDataTypes.map(t => ( | ||
| <div style={{ width: "90vw", margin: "auto" }} className="overflow-auto"> |
There was a problem hiding this comment.
左右に余白を作りたいのであれば、そもそもbootstrapのcontainerなりをしっかり利用してください。使い方などはDBのページを参考にしてください。
pages/users.tsx
Outdated
| striped | ||
| bordered | ||
| hover | ||
| style={{ tableLayout: "fixed", overflow: "scroll" }} |
There was a problem hiding this comment.
overflowはscrollだとX,Yどちらもスクロールが出てしまいます。autoにして必要な部分だけ表示されるようにしてください
MogamiTsuchikawa
requested changes
Apr 1, 2023
pages/users.tsx
Outdated
| <> | ||
| <input type="checkbox" key={t} onChange={(e) => { onCheckFilter(e.target.checked, t) }} /> | ||
| <input |
There was a problem hiding this comment.
このまま標準の使いにくいinput使うんですか？Bootstrapのcheckboxを利用してください。
概要
スクリーンショット初期状態 すべてチェックした状態 破壊的変更があるか(あれば内容を記載)
チェック項目
|
MogamiTsuchikawa
requested changes
Apr 30, 2023
MogamiTsuchikawa
requested changes
May 1, 2023
MogamiTsuchikawa
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.