Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

テーブル機能を実装 #6

Merged
merged 12 commits into from
May 2, 2023
Merged

テーブル機能を実装 #6

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
170b4a7
フィルタの項目を追加、画面左右に余白を追加
ymd1138 Mar 31, 2023
17750dd
テーブルの全項目に対してフィルタ機能を追加、有効期限のフォーマットを修正
ymd1138 Apr 11, 2023
c720d3b
チェックボックスのコードをReact Bootstrapへ変更
ymd1138 Apr 16, 2023
ce061ff
一部の項目がデフォルトで表示されるように修正、Containerを追加
ymd1138 Apr 16, 2023
e120eed
セミコロンを削除
ymd1138 Apr 16, 2023
437fd96
チェックボックスを横並びに修正、importのcurly bracketsを修正
ymd1138 Apr 28, 2023
4717367
defaultCheckedのコードをリファクタリング、marginをpaddingに修正、など
ymd1138 Apr 28, 2023
0bf8200
CSSをInline Stylesに変更
ymd1138 Apr 29, 2023
62926b0
メモを削除、importを最適に、幅表記を統一
MogamiTsuchikawa May 1, 2023
afa9c63
エラー対応処理を追加
MogamiTsuchikawa May 1, 2023
f4cc058
discordUserIdの表示幅を修正
MogamiTsuchikawa May 1, 2023
e5a5021
styleのwidthにpxがつけ忘れている部分を修正
MogamiTsuchikawa May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 45 additions & 18 deletions pages/users.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,49 @@ const UsersPage = ({ users }: Props) => {
const [selectTypes, setSelectTypes] = useState<TableDataType[]>([]);
const onCheckFilter = (checked: boolean, type: TableDataType) => {
if (checked) setSelectTypes([...selectTypes, type]);
else setSelectTypes(selectTypes.filter(t => t !== type));
}
else setSelectTypes(selectTypes.filter((t) => t !== type));
};
return (
<div style={{ width: "100%" }} className="overflow-auto">
{allTableDataTypes.map(t => (
<div style={{ width: "90vw", margin: "auto" }} className="overflow-auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

左右に余白を作りたいのであれば、そもそもbootstrapのcontainerなりをしっかり利用してください。使い方などはDBのページを参考にしてください。

{allTableDataTypes.map((t) => (
<>
<input type="checkbox" key={t} onChange={(e) => { onCheckFilter(e.target.checked, t) }} />
<input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このまま標準の使いにくいinput使うんですか？Bootstrapのcheckboxを利用してください。

type="checkbox"
key={t}
onChange={(e) => {
onCheckFilter(e.target.checked, t);
}}
/>
{t}
</>
))}
<Table striped bordered hover style={{ tableLayout: "fixed" }}>
<Table
striped
bordered
hover
style={{ tableLayout: "fixed", overflow: "scroll" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overflowはscrollだとX,Yどちらもスクロールが出てしまいます。autoにして必要な部分だけ表示されるようにしてください

>
<thead>
<tr>
{
// 幅は調整中。細かい調整は後ほど。
}
{selectTypes.indexOf("id") !== -1 ? <th style={{ width: 150 }}>ID</th> : <></>}

{/* 幅は調整中。細かい調整は後ほど。*/}
{selectTypes.indexOf("id") !== -1 ? (
<th style={{ width: 150 }}>ID</th>
) : (
<></>
)}
<th className="table-th-studentNumber">学籍番号</th>
<th className="table-th-username">ユーザー名</th>
<th style={{ width: 30 }}>学年</th>
<th style={{ width: 66 }}>アイコン</th>
<th style={{ width: 100 }}>Discord ID</th>
{selectTypes.indexOf("icon") !== -1 ? (
<th style={{ width: 66 }}>アイコン</th>
) : (
<></>
)}
{selectTypes.indexOf("discord") !== -1 ? (
<th style={{ width: 100 }}>Discord ID</th>
) : (
<></>
)}
<th style={{ width: 100 }}>有効期限</th>
<th style={{ width: 150 }}>自己紹介</th>
<th className="table-th-name">名字</th>
Expand All @@ -56,14 +76,21 @@ const UsersPage = ({ users }: Props) => {
{users.map((user) => (
<tr key={user.id}>
{selectTypes.indexOf("id") !== -1 ? <td>{user.id}</td> : <></>}

<td>{user.studentNumber}</td>
<td>{user.username}</td>
<td>{user.schoolGrade}</td>
<td>
<img src={user.iconUrl} alt="" style={{ width: "50px" }} />
</td>
<td>{user.discordUserId}</td>
{selectTypes.indexOf("icon") !== -1 ? (
<td>
<img src={user.iconUrl} alt="" style={{ width: "50px" }} />
</td>
) : (
<></>
)}
{selectTypes.indexOf("discord") !== -1 ? (
<td>{user.discordUserId}</td>
) : (
<></>
)}
<td>{user.activeLimit}</td>
<td>{user.shortIntroduction}</td>
<td>{user.firstName}</td>
Expand Down