Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Java 9 Incompatibility? #217

Closed
Bo-Fone opened this issue Nov 13, 2017 · 20 comments
Closed

Bootstrap Java 9 Incompatibility? #217

Bo-Fone opened this issue Nov 13, 2017 · 20 comments
Labels

Comments

@Bo-Fone
Copy link

Bo-Fone commented Nov 13, 2017

I just compiled the bootstrap and decided to distribute using bootstrap. But when I try to open it. I get this error:

To report this error, provide:

java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
at com.skcraft.launcher.bootstrap.HttpRequest.returnContent(HttpRequest.java:199)
at com.skcraft.launcher.bootstrap.Downloader.execute(Downloader.java:75)
at com.skcraft.launcher.bootstrap.Downloader.run(Downloader.java:42)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.JAXBException
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
... 4 more

@sk89q
Copy link
Member

sk89q commented Nov 13, 2017 via email

@Bo-Fone
Copy link
Author

Bo-Fone commented Nov 13, 2017

How do I do that? Would you mind provide me instructions or build script? Thanks a lot!

@spannerman79
Copy link

@Flinner for now either
Do what @sk89q already suggested via #216 (comment)

or

A 5 second google search and do some reading.

@sk89q
Copy link
Member

sk89q commented Nov 13, 2017 via email

@Bo-Fone
Copy link
Author

Bo-Fone commented Nov 13, 2017

Solved! Added JAXB to the build.gradle for the bootstrap. Thank you so much! However, a new issue come up. The bootstrap successfully downloaded the launcher. But the launcher sort of just hang in there, I can see the "java" runtime icon show up on my dock (macOS), but after awhile without any error message. It disappeared. And no launcher window opened. I think there's still some issue for the launcher to run under Java 9.

Please let me know how to inspect where the problem might be since it does not give me any error messages. Also, I'm quite inexperienced to programing. But I'm modestly learning, if not, trial and error, to get things working. So please bear with me if I asked some stupid question. XD

@sk89q
Copy link
Member

sk89q commented Nov 13, 2017 via email

@Bo-Fone
Copy link
Author

Bo-Fone commented Nov 13, 2017

I was trying it under my old machine which still had Java 8 on it. The newly compiled bootstrap and launcher does work on the old machine. But still, neither the bootstrap nor the launcher itself will launch in my new machine under Java 9.0.1. They do not give out any error message nor weird stuff XD. I tried to open the launcher by itself. It acts the same as I described in my last comment which the java runtime icon showed up but disappeared after a while without opening any thing nor giving me errors as if it secretly ran and hit a brick then went away.

@sk89q
Copy link
Member

sk89q commented Nov 15, 2017

Can you run it via terminal to see if Java spits out any messages?

@Bo-Fone
Copy link
Author

Bo-Fone commented Nov 15, 2017

Ah, I just searched and tried to do java -jar command, and here is the output. This time it did give me errors in terminal.

https://pastebin.com/TUJTJft5

@Bo-Fone Bo-Fone closed this as completed Nov 15, 2017
@Bo-Fone Bo-Fone reopened this Nov 15, 2017
@Bo-Fone
Copy link
Author

Bo-Fone commented Nov 15, 2017

Clicked the wrong button... Sorry..

@sk89q
Copy link
Member

sk89q commented Nov 16, 2017 via email

@kirill-grouchnikov
Copy link

I'm the developer of Substance.

The dependency on Insubstantial is using an old and no longer maintained fork of Substance. The recently released version 7.1 of Substance (Insubstantial got a bit ahead of Substance as far as versions go) should also provide much better support for high-dpi screens, with the only known issue so far being tracked in kirill-grouchnikov/substance#48

If you're interested in tracking the latest stable / dev version of Substance, I'll be glad to take a look at any crashes or visual bugs that are happening.

@Bo-Fone
Copy link
Author

Bo-Fone commented Mar 27, 2018

Hi @sk89q , Just want to know that whether the Java 9 compatibility issue has resolved. @kirill-grouchnikov is the developer of Substance. I brought him here hope that this issue could be solved. If there's something I could do, I would love to help!

@sk89q
Copy link
Member

sk89q commented Mar 27, 2018

I just haven't found time to dedicate to the problem yet.

@Bo-Fone
Copy link
Author

Bo-Fone commented Mar 27, 2018

Got it! Thanks for the reply. Just want to make sure its not forgotten 👍.

@kirill-grouchnikov
Copy link

Substance 8.0 was released last week FYI. The current release cycle is to have two releases a year, so that would be the timeframe for fixing bugs and getting the fixes into the stable releases.

@Yusixs
Copy link

Yusixs commented Jun 30, 2018

Hi @sk89q , I'm really sorry to bump this but if possible, can you please dedicate some time to fix this Java 9 issue 😅 ? We've launched our own launcher using SKCraft aswell but unfortunately, a handful of people had to downgrade from Java 9 to Java 8 to fix this issue.

It works but it's not the solution i'd like, most people will just avoid using the launcher if they had to do any further steps in order to make it work....If possible, can you fix this issue or help me on how to fix it myself over here? Thanks!

@Bo-Fone
Copy link
Author

Bo-Fone commented Jun 30, 2018

Yes. Please... We have been waiting for quite some time now. Appreciate the update in advance!

@sk89q
Copy link
Member

sk89q commented Jul 15, 2018

Let me know if it works now.

@sk89q sk89q added the bug label Jul 15, 2018
@hedgehog1029
Copy link
Member

Fancy launcher should be fixed on modern Java now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants