Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packages lockfile #1875

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add packages lockfile #1875

wants to merge 2 commits into from

Conversation

rkm
Copy link
Member

@rkm rkm commented Jul 23, 2024

Proposed Changes

Adds package restores using a lockfile.

This shouldn't be merged until Dependabot is aware of the lockfile format (dependabot/dependabot-core#1303 and dependabot/dependabot-core#9678)

We also need to properly handle restoring test packages, as they aren't included in the current lockfile.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (a6d95a1) to head (ab3dc3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   60.96%   60.96%           
=======================================
  Files         177      177           
  Lines        6559     6559           
  Branches      898      898           
=======================================
  Hits         3999     3999           
  Misses       2289     2289           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant