-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NuGet lockfiles (Updated) #9678
base: main
Are you sure you want to change the base?
Conversation
The linting failure for fetch_files is because your changes pushed the complexity over the limit. fetched_files = []
fetched_files += project_files
fetched_files += directory_build_files
fetched_files += imported_property_files
fetched_files += packages_config_files
fetched_files += nuget_config_files
fetched_files += packages_lock_files
fetched_files << global_json if global_json
fetched_files << dotnet_tools_json if dotnet_tools_json
fetched_files << packages_props if packages_props with this: fetched_files = [
*project_files,
*directory_build_files,
*imported_property_files,
*packages_config_files,
*nuget_config_files,
*packages_lock_files,
global_json,
dotnet_tools_json,
packages_props
].compact and that should reduce the complexity. |
I don't know why the test failed. It was successful when I tested it locally. |
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/UpdaterWorker.cs
Outdated
Show resolved
Hide resolved
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/UpdaterWorker.cs
Outdated
Show resolved
Hide resolved
The |
Fix #1303
Since #6031 was last updated, Dependabot NuGet logic has been rewritten as C#, so I've put this PR up.
I'm familiar with C#, but not with Ruby. I don't know how to add a test for this. Any advice is welcome.