Filter column indices of sparse matrix to ensure non-negativity #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Issue SMTorg#573, I observed that `scipy`s compressed sparse column matrix was throwing an exception about specification of negative indices. I traced this issue to the column specification in the C++ implementation of RMTB. I could not figure out what precisely was going wrong. However, by simply replacing all negative column indices with zeros, I found that the unit tests pass. This is in no way a permanent solution, but given the lack of shared understanding of this code, it is preferable to it being fully nonfunctional. While we're at it, replace all internal `int`s by `long` in order to support larger model sizes, similar to the diff made in RMTC.
NAThompson
force-pushed
the
573-negative-index
branch
from
0fdfbf6
to
ef3c381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Issue #573, I observed that
scipys compressed sparse column matrix was throwing an exception about specification of negative indices. I traced this issue to the column specification in the C++ implementation of RMTB.I could not figure out what precisely was going wrong. However, by simply replacing all negative column indices with zeros, I found that the unit tests pass. This is in no way a permanent solution, but given the lack of shared understanding of this code, it is preferable to it being fully nonfunctional.
While we're at it, replace all internal
ints bylongin order to support larger model sizes, similar to the diff made in RMTC.