-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
negative axis 1 index #573
Comments
NAThompson
added a commit
to NAThompson/smt
that referenced
this issue
May 24, 2024
In Issue SMTorg#573, I observed that `scipy`s compressed sparse column matrix was throwing an exception about specification of negative indices. I traced this issue to the column specification in the C++ implementation of RMTB. I could not figure out what precisely was going wrong. However, by simply replacing all negative column indices with zeros, I found that the unit tests pass. This is in no way a permanent solution, but given the lack of shared understanding of this code, it is preferable to it being fully nonfunctional.
NAThompson
added a commit
to NAThompson/smt
that referenced
this issue
May 24, 2024
In Issue SMTorg#573, I observed that `scipy`s compressed sparse column matrix was throwing an exception about specification of negative indices. I traced this issue to the column specification in the C++ implementation of RMTB. I could not figure out what precisely was going wrong. However, by simply replacing all negative column indices with zeros, I found that the unit tests pass. This is in no way a permanent solution, but given the lack of shared understanding of this code, it is preferable to it being fully nonfunctional. While we're at it, replace all internal `int`s by `long` in order to support larger model sizes, similar to the diff made in RMTC.
NAThompson
added a commit
to NAThompson/smt
that referenced
this issue
May 24, 2024
In Issue SMTorg#573, I observed that `scipy`s compressed sparse column matrix was throwing an exception about specification of negative indices. I traced this issue to the column specification in the C++ implementation of RMTB. I could not figure out what precisely was going wrong. However, by simply replacing all negative column indices with zeros, I found that the unit tests pass. This is in no way a permanent solution, but given the lack of shared understanding of this code, it is preferable to it being fully nonfunctional. While we're at it, replace all internal `int`s by `long` in order to support larger model sizes, similar to the diff made in RMTC.
relf
pushed a commit
that referenced
this issue
May 27, 2024
In Issue #573, I observed that `scipy`s compressed sparse column matrix was throwing an exception about specification of negative indices. I traced this issue to the column specification in the C++ implementation of RMTB. I could not figure out what precisely was going wrong. However, by simply replacing all negative column indices with zeros, I found that the unit tests pass. This is in no way a permanent solution, but given the lack of shared understanding of this code, it is preferable to it being fully nonfunctional. While we're at it, replace all internal `int`s by `long` in order to support larger model sizes, similar to the diff made in RMTC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code to reproduce:
Error:
Additional information:
Reproduces on
scipy==1.12
as well, albeit with a different error message.The text was updated successfully, but these errors were encountered: