Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk_2019 has outdated version in model_files.yml #240

Closed
JostMigenda opened this issue May 16, 2023 · 3 comments · Fixed by #254
Closed

Walk_2019 has outdated version in model_files.yml #240

JostMigenda opened this issue May 16, 2023 · 3 comments · Fixed by #254
Labels
SupernovaModel Implementing/correcting supernova model
Milestone

Comments

@JostMigenda
Copy link
Member

In model_files.yml, Walk_2019 currently lists release_version: 1.2. However, those files were updated in #211 which was released as part of v1.3, so we should update the yml file.

More generally, I think this release_version property is unnecessary; we always want to use the version of the model files that matches the SNEWPY version. Instead of fixing this one entry manually, we should see whether we can avoid manually specifying the version at all.

(Thanks to @sgriswol and another IceCube collaborator for discovering this issue!)

@JostMigenda JostMigenda added the SupernovaModel Implementing/correcting supernova model label May 16, 2023
@JostMigenda JostMigenda added this to the v1.4 milestone May 16, 2023
@sgriswol
Copy link
Contributor

To clarify our conversation, I only mentioned the Walk_2019 model, however every model in model_files.yml still lists release_version: 1.2. This issue was found by loading Walk_2019 and attempting to interpolate the luminosity/flux. Changes made between SNEWPY v1.3 and v1.2 (#211 ) fixed this issue.

An implication of this current issue is that, if model_files.yaml isn't updated appropriately when changes are made to any model, those changes will be missed when the user attempts to download the models.

@JostMigenda
Copy link
Member Author

Quick note that this also affects Zha_2021 now, see #239.

@JostMigenda
Copy link
Member Author

Note that this might be resolved as part of #250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SupernovaModel Implementing/correcting supernova model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants