Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate time entries from Walk_2019 nu_e_bar file #211

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

sgriswol
Copy link
Contributor

Fixes #210

@sgriswol
Copy link
Contributor Author

Though this PR is named fix_Walk_2019 I also found a similar issue in several of the Zha_2021 models. I have committed changes to the Zha models on Zha_2021_duplicate_times. Those model files are larger, and there are more duplicate times. To be specific, there were 3,658 duplicates out of 180,913 total entries, over 11 model files.

Given the much broader scope of these duplicates, and that in most cases the duplication seems consistent with the time being set to a fixed precision, I think the changes to the Zha models might be worth some extra consideration. I didn't see the same pattern of fixed precision in the Walk model.

Copy link
Member

@JostMigenda JostMigenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JostMigenda JostMigenda merged commit 62b8acc into main Sep 19, 2022
@JostMigenda
Copy link
Member

@evanoconnor, can you weigh in regarding the Zha_2021 model?

@evanoconnor
Copy link
Collaborator

I had a look. Most of these do indeed look like fixed precision. Near the end of the simulations the time step decreases to slightly below the output precision and once every 10 steps it seems to double the step.

Given the large number of points and the very small dt's here, the suggested change is perfectly fine.

There is just one interesting case which is the s18.dat where this only occurs once, it looks like there it may have been a restart stitching issue, but again, fine to just remove the offending lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated time entries in Walk_2019 nu_e_bar file
3 participants