Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate times from Zha_2021 models #239

Merged
merged 1 commit into from
May 23, 2023

Conversation

JostMigenda
Copy link
Member

See discussion in #211.
(@sgriswol, @evanoconnor: It looks like we forgot to follow-up on this last autumn. I just re-discovered this, so I’ll open the PR now; hope that’s okay.)

@JostMigenda JostMigenda added the SupernovaModel Implementing/correcting supernova model label May 16, 2023
@JostMigenda JostMigenda added this to the v1.4 milestone May 16, 2023
@mcolomermolla mcolomermolla self-requested a review May 23, 2023 16:32
Copy link
Collaborator

@mcolomermolla mcolomermolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes were already approved for other models, can be directly merged.

@JostMigenda JostMigenda merged commit 06a3f7b into main May 23, 2023
8 checks passed
@JostMigenda JostMigenda deleted the Zha_2021_duplicate_times branch May 23, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SupernovaModel Implementing/correcting supernova model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants