Missing directions/masses in Walk and Tamborra models

[mcolomermolla]

This PR will close issue #78.

• Incorporate data for Walk_2018 and modify README with new parameters documentation
• Incorporate data for Walk_2019 and modify README with new parameters documentation
• Include new parameters in the models class in models/ccsn.py
• Modify the notebooks with new model initialisation for Walk models
• Incorporate missing masses and directions for Tamborra_2014

For Tambora_2014, I am in touch with Irene, who told me that they did not save the theta and phi used in the three directions of the paper, so for now I can't provide all directions for all masses.

[JostMigenda]

Thanks for adding these models! A couple things I’ve noticed:

• You’ve included commits from Model registry cleanup #230 in this PR; so we should make sure to merge that one first.
• models/Walk_2018/s15.0c_3D_fastrot_dir2_LS220_nux appears to be an empty file?
• We’ve previously (remove duplicate times from Tamborra, Walk models #161, Repeated time entries in Walk_2019 nu_e_bar file #210) had some duplicate time bins in Walk model files. Could you check for duplicate lines in these files and remove them if necessary? (See e.g. this sample code snippet to save some time.)

[JostMigenda]

Regarding tests: In test_01_registry.py and test_02_models.py, the model parameters for the Walk models need to be updated as well. Also, when adding these new files, we need to bump the release_version in model_files.yml for the Walk_2018 and Walk_2019 classes to 1.3 to ensure the model downloader finds the right files.

Slight problem: Until we’ve tagged v1.3, the model downloader won’t be able to download the files, so we can’t test that. (@sgriswol, am I missing something here?)

[sgriswol]

You're right @JostMigenda, the model downloader attempts to grab models files using a URL that includes a specific version tag (1.2 currently). So until these new model are available under a specific tag, they can't be downloaded. The downloader also needs the correct version to be set in snewpy.models.model_files.yml.

Slight problem: Until we’ve tagged v1.3, the model downloader won’t be able to download the files, so we can’t test that. (@sgriswol, am I missing something here?)

[sgriswol]

I took a quick look and noticed that the new parameter options for Walk_2018 and Walk_2019 were missing from the __new__ methods in a few places. Let me know if I can help get these integrated!

[mcolomermolla]

I took a quick look and noticed that the new parameter options for Walk_2018 and Walk_2019 were missing from the __new__ methods in a few places. Let me know if I can help get these integrated!

Thanks @sgriswol for your review. Your suggested changes have been added.

[JostMigenda]

I added some small fixes for the tests. The remaining test failures are due to the download issue mentioned above; that’s unfortunately impossible to fix within the scope of this PR.

However, when I manually copy the newly added model files to the cache directory (the model_path defined in snewpy/__init__.py) on my computer and then run the tests locally, they succeed.

[JostMigenda]

Hi @mcolomermolla! I’ve reverted your last commit (updating the model notebooks), because that was already done in another PR (after this one was created), so it created a conflict with the main branch.

Otherwise this looks good; just one more update to the README, then it’s ready to merge