Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing directions/masses in Walk and Tamborra models #231

Merged
merged 22 commits into from
Jun 2, 2023
Merged

Missing directions/masses in Walk and Tamborra models #231

merged 22 commits into from
Jun 2, 2023

Commits on Nov 16, 2022

  1. Walk2018: Addition of different directions and rotation conditions data

    @mcolomermolla
    mcolomermolla committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    77bc317 View commit details
    Browse the repository at this point in the history

  2. Walk2019: Addition of different directions and 75Msun data

    @mcolomermolla
    mcolomermolla committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3244acb View commit details
    Browse the repository at this point in the history

  3. Modify ccsn.py to add additional model parameters for new initialisat… 

    …ion method
    @mcolomermolla
    mcolomermolla committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    4dd9fca View commit details
    Browse the repository at this point in the history

  4. Update python/snewpy/models/ccsn.py 

    Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
    @mcolomermolla @JostMigenda
    mcolomermolla and JostMigenda committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    76b4253 View commit details
    Browse the repository at this point in the history

  5. Update python/snewpy/models/ccsn.py 

    Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
    @mcolomermolla @JostMigenda
    mcolomermolla and JostMigenda committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    45e400e View commit details
    Browse the repository at this point in the history

  6. More details about the model parameters in the README

    @mcolomermolla
    mcolomermolla committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5f0bfa0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'mcolomer/missing_param_tamborra_walk' of https://github… 

    ….com/SNEWS2/snewpy into mcolomer/missing_param_tamborra_walk

"Modify README to include more information on model parameters"
    @mcolomermolla
    mcolomermolla committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8ee0ef2 View commit details
    Browse the repository at this point in the history

  8. Replace empty file by the correct one

    @mcolomermolla
    mcolomermolla committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    ebeee5b View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Remove duplicate bins from data files

    @mcolomermolla
    mcolomermolla committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    2dd3d93 View commit details
    Browse the repository at this point in the history

  2. Added model parameters in tests

    @mcolomermolla
    mcolomermolla committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    be0b435 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Update python/snewpy/models/ccsn.py 

    Include new parameters in check - Walk2018

Co-authored-by: Spencer Griswold <39808718+sgriswol@users.noreply.github.com>
    @mcolomermolla @sgriswol
    mcolomermolla and sgriswol committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    5dc42ff View commit details
    Browse the repository at this point in the history

  2. Update python/snewpy/models/ccsn.py 

    Add missing arguments for new parameters - Walk2018

Co-authored-by: Spencer Griswold <39808718+sgriswol@users.noreply.github.com>
    @mcolomermolla @sgriswol
    mcolomermolla and sgriswol committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    0b3b821 View commit details
    Browse the repository at this point in the history

  3. Update python/snewpy/models/ccsn.py 

    Add new parameters in check - Walk2019

Co-authored-by: Spencer Griswold <39808718+sgriswol@users.noreply.github.com>
    @mcolomermolla @sgriswol
    mcolomermolla and sgriswol committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    fa5027b View commit details
    Browse the repository at this point in the history

  4. Update python/snewpy/models/ccsn.py 

    Add missing new parameters - Walk2019

Co-authored-by: Spencer Griswold <39808718+sgriswol@users.noreply.github.com>
    @mcolomermolla @sgriswol
    mcolomermolla and sgriswol committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    224baac View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Add data for three directions in the paper for 27Msun

    @mcolomermolla
    mcolomermolla committed May 15, 2023
    Configuration menu
    Copy the full SHA
    ed0f854 View commit details
    Browse the repository at this point in the history

  2. update README

    @mcolomermolla
    mcolomermolla committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7df4faa View commit details
    Browse the repository at this point in the history

  3. Add direction parameter for 27 Msun in Tamborra_2014

    @mcolomermolla
    mcolomermolla committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9145c7f View commit details
    Browse the repository at this point in the history

  4. update tests for Tamborra 2014 including new parameters

    @mcolomermolla
    mcolomermolla committed May 15, 2023
    Configuration menu
    Copy the full SHA
    a991a79 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. fix subtle bug 

    `(1)` is an int in unnecessary brackets; an added comma makes it a tuple
    @JostMigenda
    JostMigenda committed May 16, 2023
    Configuration menu
    Copy the full SHA
    af0e3d5 View commit details
    Browse the repository at this point in the history

  2. fix tests 

    assert appropriate Errors for non-existant parameter combinations
fix missing "dir" in filename template
    @JostMigenda
    JostMigenda committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d225db1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. add also the 11.2 Msun progenitor of the paper

    @mcolomermolla
    mcolomermolla committed May 17, 2023
    Configuration menu
    Copy the full SHA
    4f73372 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. add 11 Msol to Tamborra_2014 README file

    @JostMigenda
    JostMigenda committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    2557284 View commit details
    Browse the repository at this point in the history