Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using new CCSN models repository #274

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Using new CCSN models repository #274

merged 5 commits into from
Dec 4, 2023

Conversation

Sheshuk
Copy link
Contributor

@Sheshuk Sheshuk commented Oct 5, 2023

Closes #250

@sybenzvi
Copy link
Contributor

sybenzvi commented Dec 3, 2023

This looks good. Should we also delete the model files in the model folders?

sybenzvi
sybenzvi approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@sybenzvi sybenzvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the YAML file look good. Before merging the branch, should we also delete the model files in the snewpy/models subfolder?

@Sheshuk
Copy link
Contributor Author

Sheshuk commented Dec 4, 2023

Segev, thanks for reviewing!
But looking at the YAML now, we have a mixture of "ccsn_repository" (pointing to v0.1) and "ccsnmodels"(pointing just to the main branch).
I suggest pointing all models to a new release v0.2 for consistency.

@Sheshuk
Copy link
Contributor Author

Sheshuk commented Dec 4, 2023

Before merging the branch, should we also delete the model files in the snewpy/models subfolder

Let's do this in a separate PR #294

@Sheshuk Sheshuk merged commit dfd7bfd into main Dec 4, 2023
10 checks passed
@sybenzvi sybenzvi deleted the Sheshuk/Switch_to_external_model_repository branch March 4, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sybenzvi sybenzvi sybenzvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put model files in a separate repository
2 participants
@Sheshuk @sybenzvi