Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove model files from SNEWPY #294

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Remove model files from SNEWPY #294

merged 5 commits into from
Feb 29, 2024

Conversation

Sheshuk
Copy link
Contributor

@Sheshuk Sheshuk commented Dec 4, 2023

As we moved all model files to separate repository, remove the data files from SNEWPY.

@Sheshuk Sheshuk mentioned this pull request Dec 4, 2023
Merged
@Sheshuk Sheshuk marked this pull request as ready for review December 5, 2023 13:30
@Sheshuk Sheshuk marked this pull request as draft December 5, 2023 13:31
@Sheshuk
Copy link
Contributor Author

Sheshuk commented Dec 5, 2023

Looks like we need more changes than just removing model files.
Our tests are still based on the generate_fluence functions with the old interface, so we need to implement a better interface (see #209) before we can continue.

@Sheshuk Sheshuk marked this pull request as ready for review December 5, 2023 16:26
@Sheshuk Sheshuk self-assigned this Feb 10, 2024
@sybenzvi sybenzvi self-requested a review February 29, 2024 14:11
sybenzvi
sybenzvi approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@sybenzvi sybenzvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. I'd like to see some of the notebooks going into the doc/nb folder where they will be easy to find but we can discuss in a separate issue.

@Sheshuk Sheshuk merged commit 49df97d into main Feb 29, 2024
10 checks passed
@Sheshuk Sheshuk deleted the Sheshuk/remove_model_files branch February 29, 2024 14:33
@JostMigenda JostMigenda mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sybenzvi sybenzvi sybenzvi approved these changes

Assignees

@Sheshuk Sheshuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sheshuk @sybenzvi