Run Jupyter notebooks in CI #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JostMigenda
force-pushed
the
JostMigenda/ModelNotebookTests
branch
from
5511294
to
d9e0994
Compare
Test output warns “this will become a hard error in future nbformat versions”
mcolomermolla
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
I see no issue in merging this.
Side notes:
- Maybe we can avoid the saving of pdfs figures directly on the notebook?
- For Fornax_2022: I like the way BH progenitors are handled now and that one can now pass directly a times array to get the initial spectra (good this point was solved) :)
|
Thanks @mcolomermolla! I’ve added a commit to avoid writing those files out by default; good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252 by running all (ccsn & presn) model notebooks and some general notebooks as part of the integration tests.
(For now, I’m exempting several general notebooks, which e.g. require a hard-coded path to the SNOwGLoBES or models directory. In some cases, there may be workarounds; but it’s gonna get more straightforward with some of the changes planned for v2.0.)
As a nice side effect of testing this, I discovered a few issues with existing notebooks which I’ve also fixed. (In particular, the notebooks I copied over from the
snewpy-models-ccsnrepo in #313 were not the latest versions and missed changes from #282, so I’m restoring those here.)