Fix bulk downloader #325
Merged
Fix bulk downloader #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* will now download to `model_path` instead of current directory * deprecate `download_dir` argument, which was never officially documented
Closed
Sheshuk
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more problem discovered while preparing the v1.5 release: The bulk downloader (
snewpy.get_models()) broke when moving model files to separate repositories.This PR fixes it and ensures it uses the same download code as model initialisers (iterating over all parameter_combinations, rather than using its own dictionary of hardcoded file names); to avoid future breakage.
As a side effect, the bulk downloader will now download to the same
snewpy.model_path, rather then the current directory. This is good for consistency and may avoid duplicate downloads.The parameter
download_dirwas never officially documented; I’m still marking it as deprecated though, to be safe.