-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp CMake support #1118
base: master
Are you sure you want to change the base?
Revamp CMake support #1118
Conversation
Do you think we should wait for this before making SOCI 4.1.0 release or can we leave this change until a later 4.1.x? |
Well, it would probably be nice if 4.1 had this already, but it's more of a nice-to-have. So I guess you don't have to wait for this PR to be done. Unrelated to this PR, I would appreciate if #992 made it into 4.1 though :) |
7815446
to
c8d5da6
Compare
0b83bb8
to
e1e4433
Compare
e4b2e0d
to
39b9037
Compare
60bb010
to
793ad26
Compare
That way no compiler should ever emit a warning about something in the associated header files and thus we don't have to jump through hoops in order to avoid warnings that we can't do anything about.
d0d1c57
to
e3996d5
Compare
As I wrote in #1153, the header really should be renamed/moved, so it's not directly related to this PR, but please let me know when this one will be ready for review in any case. Thanks! |
Fixes #1115