Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass resolved value to inner-next when fallback. #184

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Pass resolved value to inner-next when fallback. #184

merged 4 commits into from
Nov 13, 2022

Conversation

Endermanbugzjfc
Copy link
Collaborator

@Endermanbugzjfc Endermanbugzjfc commented Nov 5, 2022 •
edited
Loading

No description provided.

@Endermanbugzjfc
Copy link
Collaborator Author

My fork is so broken...

@Endermanbugzjfc Endermanbugzjfc marked this pull request as ready for review November 5, 2022 16:15
@Endermanbugzjfc Endermanbugzjfc marked this pull request as draft November 5, 2022 16:15
Endermanbugzjfc added a commit to Endermanbugzjfc/FormInteractionFix that referenced this pull request Nov 5, 2022
@Endermanbugzjfc
Use SOF3/await-generator#184.
807dac0
@codecov
Copy link

codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Base: 99.42% // Head: 99.42% // No change to project coverage 👍

Coverage data is based on head (27fa383) compared to base (a6f328b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #184   +/-   ##
=========================================
  Coverage     99.42%   99.42%           
  Complexity      127      127           
=========================================
  Files            10       10           
  Lines           345      345           
=========================================
  Hits            343      343           
  Misses            2        2
Impacted Files Coverage Δ
...it-generator/src/SOFe/AwaitGenerator/Traverser.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Endermanbugzjfc Endermanbugzjfc marked this pull request as ready for review November 6, 2022 15:41
@Endermanbugzjfc
Copy link
Collaborator Author

Succeeded test: https://github.com/Endermanbugzjfc/FormInteractionFix/actions/runs/3404951846/jobs/5662566002

@Endermanbugzjfc
Copy link
Collaborator Author

Please do not forget to bump version number and create release tag, thanks.

@SOF3
Copy link
Owner

SOF3 commented Nov 7, 2022

can you add unit tests to show what this has fixed?

@Endermanbugzjfc
Copy link
Collaborator Author

can you add unit tests to show what this has fixed?

In await-generator?

@SOF3
Copy link
Owner

SOF3 commented Nov 8, 2022

can you add unit tests to show what this has fixed?

In await-generator?

yes, bug fixes should also include a unit test case that used to fail but no longer fails

@Endermanbugzjfc
Copy link
Collaborator Author

can you add unit tests to show what this has fixed?

In await-generator?

yes, bug fixes should also include a unit test case that used to fail but no longer fails

Done.

@SOF3
Copy link
Owner

SOF3 commented Nov 13, 2022 •
edited
Loading

Please do not forget to bump version number and create release tag, thanks.

will do tomorrow, please remind me if I forget

@SOF3 SOF3 merged commit c6fa008 into SOF3:master Nov 13, 2022
@Endermanbugzjfc Endermanbugzjfc deleted the patch-idk branch November 13, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SOF3 SOF3 SOF3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Endermanbugzjfc @SOF3